Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the compass rose translation gizmo to the transform cage #2277

Merged
merged 25 commits into from
Feb 15, 2025

Conversation

mTvare6
Copy link
Contributor

@mTvare6 mTvare6 commented Feb 10, 2025

Closes #2282:

  • The rotation/scaling grip/handle squares should rotate with the layer, not with the viewport. Notice how the layer has a local rotation and the grips use that rotation.
  • We want to put a ring in the center that can be dragged to translate the transform cage. This is important for non-filled shapes which have no selection area inside them. In the image below, you'll see the click target in translucent blue. That light blue should appear when it or the solid ring is hovered. (Inside the ring is not a click target though, since it needs to give space for the pivot widget to be draggable.)
  • That ring should have local-axis constrained drag arrows. Either side of the arrow (left/right; or up/down) is equivalent. Similar functionality to G X X or G Y Y but without actually being in G/R/S mode and no seeing the number overlays, etc. But we do want an overlay that is just a dashed line through the dragged arrow points going through the entire viewport. It should b either red or green to match the arrow being dragged. Collectively we call the ring and arrows the "compass rose" if you want to use that for your variable names.

@mTvare6 mTvare6 marked this pull request as draft February 10, 2025 13:41
@mTvare6 mTvare6 marked this pull request as ready for review February 11, 2025 13:27
@Keavon
Copy link
Member

Keavon commented Feb 11, 2025

!build

Copy link

📦 Build Complete for 13e2a3c
https://4ba0f174.graphite.pages.dev

@Keavon Keavon marked this pull request as draft February 11, 2025 23:18
@Keavon
Copy link
Member

Keavon commented Feb 12, 2025

!build

Copy link

📦 Build Complete for d7bdda3
https://2d7fb363.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Feb 12, 2025

!build

Copy link

📦 Build Complete for f5bf218
https://33c1859b.graphite.pages.dev

@mTvare6 mTvare6 marked this pull request as ready for review February 12, 2025 13:17
@Keavon
Copy link
Member

Keavon commented Feb 12, 2025

!build

Copy link

📦 Build Complete for cac48de
https://f5b9eb4c.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Feb 13, 2025

!build

Copy link

📦 Build Complete for e9ec785
https://10e1349b.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Feb 13, 2025

!build

Copy link

📦 Build Complete for b4ca941
https://4a541b55.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Feb 13, 2025

!build

Copy link

📦 Build Complete for 6b87674
https://8b19645d.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Feb 13, 2025

!build

Copy link

📦 Build Complete for f442d54
https://aff4249c.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Feb 13, 2025

Please de-conflate the pivot and compass rose by moving compass rose code into its own file. I've pushed some initial work towards that, but you'll need to finish it from here to get it to compile since I need to move on to other tasks.

@Keavon Keavon changed the title Xform cage viz Add the compass rose translation gizmo to the transform cage Feb 15, 2025
@Keavon Keavon merged commit 70b4bea into GraphiteEditor:master Feb 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compass rose translation gizmo in the Select tool's transform cage
2 participants